Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set accept_ra=2 to fix missing ipv6 address on WAN interface if necessary #504

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Apr 23, 2024

Background

bindLan setting conf.ipv6.all.forwarding=1 suppresses accept_ra=1, thus we set it 2 as a workaround.
See https://sysctl-explorer.net/net/ipv6/accept_ra/ for more information.

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #463

Test Result

@mzz2017 mzz2017 requested review from a team as code owners April 23, 2024 16:57
@mzz2017 mzz2017 changed the title fix: set accept_ra=2 if necessary to fix missing ipv6 address on WAN interface fix: set accept_ra=2 to fix missing ipv6 address on WAN interface if necessary Apr 23, 2024
@mzz2017 mzz2017 added the documentation Improvements or additions to documentation label Apr 23, 2024
jschwinger233
jschwinger233 previously approved these changes Apr 23, 2024
Copy link
Member

@jschwinger233 jschwinger233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SysctlManager.Get() 的小问题

control/sysctl.go Outdated Show resolved Hide resolved
@dae-prow
Copy link
Contributor

dae-prow bot commented May 30, 2024

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

Copy link
Member

@jschwinger233 jschwinger233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@sumire88 sumire88 merged commit 3d68dba into main Jun 11, 2024
29 checks passed
@sumire88 sumire88 deleted the mzz/set_acceptra_2 branch June 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation fix tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] <pve下WAN口使用vlan时自动配置内核参数路径出现问题>
3 participants