fix: Opt out TCP sockmap bypass by default #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the kernel issue[1] is fixed and backported to TLS, I'll open another pull request as a follow-up to automatically enable this option if kernel has the patches. [1]: https://github.com/jschwinger233/bpf_msg_redirect_bug_reproducer Signed-off-by: gray <gray.liang@isovalent.com>
|
Thanks for raising this. Is there any correlation between #505 and this PR? |
Most likely not. This feature only affects local TCP, shouldn't have something to do with WAN UDP. |
mzz2017
approved these changes
May 17, 2024
sumire88
approved these changes
May 18, 2024
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the kernel issue1 is fixed and backported to TLS, I'll open another pull request as a follow-up to automatically enable this option if kernel has the patches.
Background
A kernel issue (confirmed by community) breaks TCP clients (e.g. glider) who use splice syscall when enabling bpf sockmap redirect. This PR opts out that performance optimization until kernel bug is fixed.
Checklist
Full Changelogs
Issue Reference
Closes #[issue number]
Test Result