Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): shell completion subcommand #576

Merged
merged 3 commits into from
Jul 23, 2024
Merged

feat(cmd): shell completion subcommand #576

merged 3 commits into from
Jul 23, 2024

Conversation

zzzsyyy
Copy link
Contributor

@zzzsyyy zzzsyyy commented Jul 10, 2024 •
edited
Loading

Background

This PR adds support for auto-generated shell completions subcommand for dae, including Bash, Zsh, and Fish. avoids the need to modify the install/shell-completions each time.

Checklist

Full Changelogs

  • feat: shell completion subcommand for [bash|fish|zsh]

Issue Reference

Test Result

bash

图片

fish
截图 2024-07-22 09-16-12
截图 2024-07-22 09-15-49

zsh
截图 2024-07-22 09-33-10

图片

@zzzsyyy zzzsyyy requested a review from a team as a code owner July 10, 2024 11:02
@sumire88
Copy link
Contributor

@zzzsyyy Do you mind providing any test results please?

@zzzsyyy
Copy link
Contributor Author

zzzsyyy commented Jul 22, 2024

@zzzsyyy Do you mind providing any test results please?

Test results added

dae-prow[bot]
dae-prow bot approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@sumire88 sumire88 changed the title feat: shell completion subcommand feat(cmd): shell completion subcommand Jul 23, 2024
sumire88
sumire88 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@sumire88 sumire88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@sumire88 sumire88 merged commit 4717fa2 into daeuniverse:main Jul 23, 2024
8 checks passed
@zzzsyyy zzzsyyy deleted the feat/completion branch July 23, 2024 04:48
@shenghuang147 shenghuang147 mentioned this pull request Jul 25, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow approved these changes

@sumire88 sumire88 sumire88 approved these changes

Assignees

@zzzsyyy zzzsyyy

Labels
feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zzzsyyy @sumire88