Create migration for converting to bigint ids #16057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangenfeld
reviewed
Aug 24, 2023
jmsanders
previously requested changes
Aug 29, 2023
python_modules/dagster/dagster/_core/storage/migration/bigint_migration.py
Outdated
Show resolved
Hide resolved
prha
force-pushed
the
prha/bigint_migration
branch
from
b76ec49
to
1c37a3a
Compare
prha
force-pushed
the
prha/bigint_migration
branch
from
1c37a3a
to
9e468b9
Compare
jmsanders
approved these changes
Sep 12, 2023
zyd14
pushed a commit
to zyd14/dagster
that referenced
this pull request
Sep 15, 2023
## Summary & Motivation Creates an optional schema migration (may incur downtime) to convert all table ids from int => bigint. This is run outside of the alembic machinery, since it is optional and can be applied at any time. This uses the db inspector to convert the `id` column of any known tables. ## How I Tested These Changes BK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Creates an optional schema migration (may incur downtime) to convert all table ids from int => bigint.
This is run outside of the alembic machinery, since it is optional and can be applied at any time. This uses the db inspector to convert the
idcolumn of any known tables.How I Tested These Changes
BK