Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov config adjustment #665

Merged
merged 12 commits into from
Aug 18, 2024
Merged

Codecov config adjustment #665

merged 12 commits into from
Aug 18, 2024

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Aug 16, 2024

No description provided.

@yohamta yohamta merged commit 6b14de2 into main Aug 18, 2024
4 checks passed
@yohamta yohamta deleted the codecov-config branch August 18, 2024 06:07
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 65.92593% with 46 lines in your changes missing coverage. Please review.

Project coverage is 64.93%. Comparing base (765fa19) to head (449b294).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/persistence/jsondb/jsondb.go 69.04% 16 Missing and 10 partials ⚠️
internal/persistence/jsondb/writer.go 56.75% 8 Missing and 8 partials ⚠️
internal/client/client.go 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   65.12%   64.93%   -0.19%     
==========================================
  Files          53       53              
  Lines        4278     4284       +6     
==========================================
- Hits         2786     2782       -4     
+ Misses       1263     1250      -13     
- Partials      229      252      +23     
Files Coverage Δ
internal/dag/builder.go 78.86% <100.00%> (+0.33%) ⬆️
internal/dag/scheduler/node.go 85.12% <100.00%> (+0.18%) ⬆️
internal/persistence/client/store_factory.go 92.00% <100.00%> (ø)
internal/client/client.go 74.66% <42.85%> (-1.14%) ⬇️
internal/persistence/jsondb/writer.go 64.44% <56.75%> (-35.56%) ⬇️
internal/persistence/jsondb/jsondb.go 74.78% <69.04%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765fa19...449b294. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant