Adds optional securestring password constructor #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahall
requested changes
Jul 10, 2023
TaskService/TaskService.cs
Outdated
| /// The password that is used to connect to the computer as a SecureString. If the user name and securePassword are not specified, then the current token is used. | ||
| /// </param> | ||
| /// <param name="forceV1">If set to <c>true</c> force Task Scheduler 1.0 compatibility.</param> | ||
| public TaskService(string targetServer, string userName = null, string accountDomain = null, SecureString userSecurePassword = null, bool forceV1 = false) |
There was a problem hiding this comment.
Please change to the following to disambiguate from other ctor with optional params:
public TaskService(string targetServer, [Optional] string userName, [Optional] string accountDomain, [Optional] SecureString userSecurePassword, bool forceV1 = false)
chrisdent-de
added a commit
to chrisdent-de/TaskScheduler
that referenced
this pull request
Jul 21, 2023
dahall
pushed a commit
that referenced
this pull request
Jul 31, 2023
dahall
added a commit
that referenced
this pull request
May 24, 2024
…l password and causes access denied in ctor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #967