Allow a comma-separated list of local prefixes, like goimports #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeShu
force-pushed
the
lukeshu/multi-local
branch
from
f900694
to
8a38bd1
Compare
|
Could you sign your commits? @LukeShu |
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
LukeShu
force-pushed
the
lukeshu/multi-local
branch
from
8a38bd1
to
cc687a8
Compare
|
Sure thing. I've now signed the commit. @daixiang0 |
ngehrsitz
pushed a commit
to ngehrsitz/gci
that referenced
this pull request
Dec 13, 2021
I implemented this in daixiang0#33 but forgot to update README.md Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gci's limitation that it only takes a single prefix came as a surprise to me, and is blocking my employer from switching fromgoimportstogci(either way viagolangci-lint) for multiple repos, and is forcing us to switch fromgcitogoimportson another.