Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Add initial GitHub Issue/PR templates #456

Merged

Conversation

obbardc
Copy link
Contributor

@obbardc obbardc commented Sep 12, 2024

What

This PR implements GitHub templates for new issues/PRs.

Why

This is so I don't annoy @dalathegreat when opening PRs which do not follow the standard format ;-).

How

Following github documentation to create the templates.

PS: Feel free to improve by editing the commit or commenting here. I will collect all changes.

@obbardc obbardc changed the title Add basic GitHub Issue/PR templates Improvement: Add initial GitHub Issue/PR templates Sep 12, 2024
@amarofarinha
Copy link
Collaborator

very nice!

Can i suggest including the next items for issues template? this information could greatly facilitate the initial diagnosis of the issue raised

  • Software Version
  • battery used
  • inverter communication protocol
  • hardware used for Battery-Emulator (LILYGO, STARK )
  • CONTACTOR_CONTROL (yes/no)
  • DUAL_CAN (yes7no)
  • WEBSERVER /yes/no)
  • MQTT (yes/no)

@obbardc
Copy link
Contributor Author

obbardc commented Sep 12, 2024

I thought about having separate templates for bug/feature request too, which could add labels to the resultant issue.

Signed-off-by: Christopher Obbard <obbardc@gmail.com>
@dalathegreat dalathegreat merged commit e485abe into dalathegreat:main Sep 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants