use _.each everywhere instead of the _.forEach alias

env.js

@@ -144,7 +144,7 @@ function findExtendedSettings (envs) {
     return key.toUpperCase().replace('CUSTOMCONNSTR_', '');
   }
 
-  _.forEach(env.settings.enable, function eachEnable(enable) {
+  _.each(env.settings.enable, function eachEnable(enable) {
     if (_.trim(enable)) {
       _.forIn(envs, function eachEnvPair (value, key) {
         var env = normalizeEnv(key);

lib/data.js

@@ -223,7 +223,7 @@ function init(env, ctx) {
       }
     }
 
-    _.forEach(data.treatments, updateTreatmentBG);
+    _.each(data.treatments, updateTreatmentBG);
 
   };
 

lib/plugins/boluswizardpreview.js

@@ -192,7 +192,7 @@ function profileFieldsMissing (sbx) {
 function pushInfo(prop, info, sbx) {
   if (prop && prop.errors) {
     info.push({label: 'Notice', value: 'required info missing'});
-    _.forEach(prop.errors, function pushError (error) {
+    _.each(prop.errors, function pushError (error) {
       info.push({label: '  • ', value: error});
     });
   } else if (prop) {

lib/plugins/cannulaage.js

@@ -62,7 +62,7 @@ cage.findLatestTimeChange = function findLatestTimeChange(sbx) {
 
   var prevDate = 0;
 
-  _.forEach(sbx.data.treatments, function eachTreatment (treatment) {
+  _.each(sbx.data.treatments, function eachTreatment (treatment) {
     var treatmentDate = treatment.mills;
     if (treatment.eventType === 'Site Change' && treatmentDate > prevDate && treatmentDate <= sbx.time) {
 

lib/plugins/cob.js

@@ -45,7 +45,7 @@ function init() {
     var isDecaying = 0;
     var lastDecayedBy = 0;
 
-    _.forEach(treatments, function eachTreatment(treatment) {
+    _.each(treatments, function eachTreatment(treatment) {
       if (treatment.carbs && treatment.mills < time) {
         lastCarbs = treatment;
         var cCalc = cob.cobCalc(treatment, profile, lastDecayedBy, time);

lib/plugins/index.js

@@ -56,7 +56,7 @@ function init() {
   };
 
   plugins.register = function register(all) {
-    _.forEach(all, function eachPlugin(plugin) {
+    _.each(all, function eachPlugin(plugin) {
       allPlugins.push(plugin);
     });
   };
@@ -68,7 +68,7 @@ function init() {
       return settings.enable.indexOf(plugin.name) > -1;
     }
 
-    _.forEach(allPlugins, function eachPlugin(plugin) {
+    _.each(allPlugins, function eachPlugin(plugin) {
       plugin.enabled = isEnabled(plugin);
       if (plugin.enabled) {
         enabledPlugins.push(plugin);
@@ -78,11 +78,11 @@ function init() {
   };
 
   plugins.eachPlugin = function eachPlugin(f) {
-    _.forEach(allPlugins, f);
+    _.each(allPlugins, f);
   };
 
   plugins.eachEnabledPlugin = function eachEnabledPlugin(f) {
-    _.forEach(enabledPlugins, f);
+    _.each(enabledPlugins, f);
   };
 
   //these plugins are either always on or have custom settings
@@ -95,7 +95,7 @@ function init() {
   };
 
   plugins.eachShownPlugins = function eachShownPlugins(sbx, f) {
-    _.forEach(plugins.shownPlugins(sbx), f);
+    _.each(plugins.shownPlugins(sbx), f);
   };
 
   plugins.hasShownType = function hasShownType(pluginType, sbx) {
@@ -136,7 +136,7 @@ function init() {
 
   plugins.extendedClientSettings = function extendedClientSettings (allExtendedSettings) {
     var clientSettings = {};
-    _.forEach(clientDefaultPlugins, function eachClientPlugin (plugin) {
+    _.each(clientDefaultPlugins, function eachClientPlugin (plugin) {
       clientSettings[plugin.name] = allExtendedSettings[plugin.name];
     });
     return clientSettings;

lib/plugins/iob.js

@@ -31,7 +31,7 @@ function init() {
 
     var lastBolus = null;
 
-    _.forEach(treatments, function eachTreatment(treatment) {
+    _.each(treatments, function eachTreatment(treatment) {
       if (treatment.mills <= time) {
         var tIOB = iob.calcTreatment(treatment, profile, time);
         if (tIOB.iobContrib > 0) {

lib/plugins/maker.js

@@ -100,7 +100,7 @@ function init (env) {
   maker.makeKeyRequests = function makeKeyRequests(event, eventName, callback) {
     var selectedKeys = event.isAnnouncement ? announcementKeys : keys;
 
-    _.forEach(selectedKeys, function eachKey(key) {
+    _.each(selectedKeys, function eachKey(key) {
       maker.makeKeyRequest(key, event, eventName, callback);
     });
   };

lib/plugins/pluginbase.js

@@ -92,7 +92,7 @@ function init (majorPills, minorPills, statusPills, bgStatus, tooltip) {
   };
 
   pluginBase.addForecastPoints = function addForecastPoints (points) {
-    _.forEach(points, function eachPoint (point) {
+    _.each(points, function eachPoint (point) {
       point.type = 'forecast';
       if (point.mgdl < 13) {
         point.color = 'transparent';

lib/plugins/pushover.js

@@ -35,7 +35,7 @@ function init (env) {
       }
     }
 
-    _.forEach(selectedKeys, function eachKey(key) {
+    _.each(selectedKeys, function eachKey(key) {
       msg.user = key;
       pushover.sendAPIRequest(msg, callback);
     });

lib/profilefunctions.js

@@ -24,7 +24,7 @@ function init(profileData) {
 
   // preprocess the timestamps to seconds for a couple orders of magnitude faster operation
   profile.preprocessProfileOnLoad = function preprocessProfileOnLoad(container) {
-    _.forEach(container, function eachValue (value) {
+    _.each(container, function eachValue (value) {
       if( Object.prototype.toString.call(value) === '[object Array]' ) {
         profile.preprocessProfileOnLoad(value);
       }
@@ -67,7 +67,7 @@ function init(profileData) {
     returnValue = valueContainer;
 
     if( Object.prototype.toString.call(valueContainer) === '[object Array]' ) {
-      _.forEach(valueContainer, function eachValue (value) {
+      _.each(valueContainer, function eachValue (value) {
         if (timeAsSecondsFromMidnight >= value.timeAsSeconds) {
           returnValue = value.value;
         }

lib/pushnotify.js

@@ -67,7 +67,7 @@ function init(env, ctx) {
     if (ctx.pushover) {
       var receiptKeys = receipts.keys();
 
-      _.forEach(receiptKeys, function eachKey(receipt) {
+      _.each(receiptKeys, function eachKey(receipt) {
         ctx.pushover.cancelWithReceipt(receipt, function cancelCallback(err) {
           if (err) {
             console.error('error canceling receipt, err: ', err);

static/profile/js/profileeditor.js

@@ -251,7 +251,7 @@
     }
 
     // Fill dropdown boxes
-    _.forEach([{prefix:'pe_basal', array:'basal', label:'Rate: '},
+    _.each([{prefix:'pe_basal', array:'basal', label:'Rate: '},
      {prefix:'pe_ic', array:'carbratio', label:'IC: '},
      {prefix:'pe_isf', array:'sens', label:'ISF: '}
     ], function (e) {