Fix for a regression with image sizing when specifiying both a max-width #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a max-height. This just did not work correctly, it broke the layout. We must respect the scaling factor between instrinct-sizes and css-sizes. This was already fixed in the too small case, but not in the other case.
|
Thanks @rototor, I don't know how I missed this. Even the comment above hints at the correct code! Are the images OK to relicense as LGPL? If not I probably should change them. |
|
@danfickle This are customer pictures, so it would be better if you could replace them. |
danfickle
added a commit
that referenced
this pull request
Aug 20, 2019
Was broken when intrinsic width or height were greater than max-width or max-height. Thanks again @rototor. Public domain images provided by pexabay at www.pexels.com Co-Authored-By: Emmeran Seehuber <rototor@rototor.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and a max-height. This just did not work correctly, it broke the layout.
We must respect the scaling factor between instrinct-sizes and css-sizes.
This was already fixed in the "too small case", but not in the other case.
Feel free to replace the sample images with something else. Just make sure that they are big enough.