Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang and title support for span tag #400

Closed
wants to merge 1 commit into from

Conversation

Ignaciort91
Copy link

We are working on PDF's with accessibility support and we find two use cases not contemplated until the moment in the span tags:

@Ignaciort91 Ignaciort91 marked this pull request as ready for review October 30, 2019 12:32
@danfickle
Copy link
Owner

Thanks a lot for putting this effort in @Ignaciort91. Much appreciated.

After some research it seems that the PDF reference recommends using the expanded entry for acronyms and abbreviations. The alternate entry is typically used for content with no textual equivalent such as images or symbol fonts.

The abbr tag is typically used for this purpose in HTML. As you point out the title and lang attributes can be used on any tag in html.

So here is what I'll do:

  • Special case the abbr tag (by copying, pasting and editing your code) to specify acronyms and abbreviations, setting the expanded entry on the structural element from the title attribute.
  • Make sure all tags handle the title and lang attributes. All tags, except abbr will use the title attribute to set the alternate text. Therefore, users will have the choice of using abbr, span, or another tag as appropriate.
  • Add abbr tag and span with lang and title attributes to the all-in-one PDF-UA test case.

Thanks again,
Daniel.

danfickle added a commit that referenced this pull request Nov 1, 2019
Big thanks to @Ignaciort91 whose code this is based on.
@Ignaciort91
Copy link
Author

Excellent! Thank you @danfickle for your prompt implementation and in a more generic way. I think that these types of improvements are very useful to help people with difficulties and make the library much more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants