In PrimitivePropertyBuilder.Src -> try to narrow down the PropertyValue list to a single value. This allow to link directly a google font css

[syjer]

Hi @danfickle , looking at the issue #422 I was wondering why it skipped totally the src property in the following declaration:

@font-face {
  font-family: 'PT Sans';
  font-style: normal;
  font-weight: 400;
  src: local('PT Sans'), local('PTSans-Regular'), url(https://fonts.gstatic.com/s/ptsans/v11/jizaRExUiTo99u79D0KEwA.ttf) format('truetype');
}

It looks like GenericURIWithNone (which Src extends) accept only a list with a single element, thus ignoring the src declaration.

Adding a logic to get the first matching element which is not a unknown css type seems to be a decent heuristic.

As you can see from the test, you can now simply link a css from google fonts and it will work!

WDYT? :)

EDIT: by the way, I've noticed CSSParser & co is not fully generified (lot of raw List parameters/types), are you interested in a small cleanup of that class? I think I can provide a PR :D

[danfickle]

Hi @syjer,

Thanks for the effort on this. However, I haven't used it directly as I thought it could be made a bit more robust by checking the format tag after the uri.

Also, I'm trying to minimise network loads in the tests because my mac is getting slower and slower running them. On this note, could you please consider, when making a test using the @page size property to size the page as small as possible (to fit the test). This means less pixels to compare.

Thanks again,
Daniel.

[syjer]

@danfickle thank you for taking care of it :) I agree with your changes.

On this note, could you please consider, when making a test using the @page size property to size the page as small as possible (to fit the test). This means less pixels to compare.

Sure, I didn't know about this issue at all 👍