Java2D - Ability to add fonts via code and manual test harness. #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With some refactoring of PDF test harness to share code.
Also reduced anti-alias threshold from 25 to 7. This makes text readable. With test.
Environment fonts were disabled by default in the last commit to avoid variable results among different machines. They can be re-enabled with: builder.useEnvironmentFonts(true);
|
I think this is a good move. Will make things reproducible and less dependent on environment. Looking forward to it. |
I should know by now not to resolve conflicts with the web interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manual tests can be run from:
openhtmltopdf-examples\src\main\java\com\openhtmltopdf\testcases\j2d\Java2DVisualTest.javaThese tests are manual because Java2D rendering is not pixel identical across JREs, OSs, etc.
IF a test fails it will output an actual image, expected image and diff image at:
working-directory\target\test\visual-tests\test-output\j2d. The working directory will usually be theopenhtmltopdf-examplesmodule directory. If not there, check the parent directory as well.From the diff image you will be able to work out if there is a bug in this library, or just a minor rendering difference by the JRE.
NOTE: Change to default behavior: Java2D will no longer pull in local machine fonts by default. To return to the previous behavior:
Otherwise, you should provide at least one font and use it on the body tag.
This change is to avoid differing behavior on development machine vs server.