Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better handling of href uri #469 #470

Merged
merged 1 commit into from
Apr 30, 2020
Merged

better handling of href uri #469 #470

merged 1 commit into from
Apr 30, 2020

Conversation

syjer
Copy link
Contributor

@syjer syjer commented Apr 28, 2020

Hi @danfickle , this fix the issue #469 . As the email URI was not matched by "://" I decided to directly use the URI.create route :).

I've tested with http:// and mailto: manually and they both work now.

@syjer syjer mentioned this pull request Apr 28, 2020
@danfickle danfickle merged commit 705cfd2 into danfickle:open-dev-v1 Apr 30, 2020
@danfickle
Copy link
Owner

Thanks again @syjer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants