Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #474 NPE when base64 decoding fail #490

Merged
merged 1 commit into from
May 27, 2020
Merged

fix issue #474 NPE when base64 decoding fail #490

merged 1 commit into from
May 27, 2020

Conversation

syjer
Copy link
Contributor

@syjer syjer commented May 25, 2020

Hi @danfickle , this fix the issue #474 . When loadEmbeddedBase64ImageResource fail, it will return a ImageResource with a null image. We check before calling realize()

@danfickle danfickle merged commit 5fb570d into danfickle:open-dev-v1 May 27, 2020
@danfickle danfickle mentioned this pull request Jul 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syjer @danfickle