-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DATABASE_MAX_CONNS config setting #1108
Add DATABASE_MAX_CONNS config setting #1108
Conversation
Just spotted that this is a duplicate of #949 - feel free to close this one. |
This one is actually passing the checks and the other one isn't ;) |
Would love to see this PR merged in. When I tried to deploy bitwarden_rs today, it filled up all of my pgpool connections. I find it kinda crazy that it needs 10 simultaneous connections to the database. +1 |
this PR has some conflicts so a simple merge is not possible. |
I’ll fix the conflicts later if I have time |
Well, there arn't any conflicts it seems. But i do have one remark. It would be best if there is some validation done on the input value. So i think at least a check that is is 1 or higher, maybe even a max, because i wouldn't want to have 1000 connections to my database by accident. |
Updated in b9daa59 |
LGTM, and since there seems to be quite some request about this i think it is fine by me. |
…setting Add DATABASE_MAX_CONNS config setting
Tiny change to allow the database connection pool size to be configured externally (useful for those of us deploying to databases with limited connection count allowances)