Upgrade to latest sbt version and refactor Java version validation #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to add scalariform to the community build.
Previously, validation of required version was done during loading of build definition. This was needlessly restricting because not everything in scalariform requires particular Java version. After closer inspection, it turns out that only the `misc` subproject depends on Swing and cares about the specific Java version. We refactor validation logic to run right before `compile` task in `misc` subproject. That makes it possible to ignore this subproject and build the rest of scalariform on any Java version.
gkossakowski
added a commit
to gkossakowski/community-builds
that referenced
this pull request
Jan 23, 2015
The git reference points at pull request that fixes some issues in scalariform's build definition that prevented it from building by dbuild. Check the PR for details: daniel-trinh/scalariform#42
When resolving Scala-version specific dependencies, match any Scala 2.11 release and not just 2.11.0.
Match in the build definition Scala version that includes qualifier. The qualifier is in the form of hyphen and word characters following minor version. E.g. this change enables matching Scala version like: 2.11.6-dbuildx7765235bd36ec60fc0c730b29c692e1bc2864526 that are being used by dbuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check individual commit messages for details.
The changes I'm submitting will make it possible to add scalariform to community build.