Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging when linked with C++ binary #16

Merged
merged 7 commits into from
Jun 13, 2020
Merged

Fix logging when linked with C++ binary #16

merged 7 commits into from
Jun 13, 2020

Commits on Jun 13, 2020

  1. When the the libcachegrand-internal gets linked with a C++ executable… 

    … (ie. for testing or benchmarking) the strftime cause a sigsegv, switching to a plain sprintf because strfime it's used in a real basic way
    @danielealbano
    danielealbano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    344e748 View commit details
    Browse the repository at this point in the history

  2. The log_message_timestamp_format define is not used anymore

    @danielealbano
    danielealbano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    31d1440 View commit details
    Browse the repository at this point in the history

  3. No need to pass the size to the log_message_timestamp, it's not reque… 

    …st (or neither checked) by sprintf
    @danielealbano
    danielealbano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    2714eae View commit details
    Browse the repository at this point in the history

  4. Do not pass LOG_MESSAGE_TIMESTAMP_MAX_LENGTH to the log_message_times… 

    …tamp function anymore
    @danielealbano
    danielealbano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    cdeb827 View commit details
    Browse the repository at this point in the history

  5. Pre-initialize t_str to zeros

    @danielealbano
    danielealbano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    1c96d97 View commit details
    Browse the repository at this point in the history

  6. Update the function signature in log.c

    @danielealbano
    danielealbano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    bdb39c0 View commit details
    Browse the repository at this point in the history

  7. tm is a pointer, it's not allocated on the stack

    @danielealbano
    danielealbano committed Jun 13, 2020
    Configuration menu
    Copy the full SHA
    a914c71 View commit details
    Browse the repository at this point in the history