-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for RMW operations and update the SET command to use them when needed #179
Merged
danielealbano
merged 20 commits into
main
from
173-implement-support-for-read-modify-write-operations-in-the-hashtable-and-in-the-storage-db
Aug 17, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or the mpmc hashtable
…he internal interface
…okens using RMW operations
…ength in storage_db_get_entry_index_prep_for_read
…d add storage_db_op_rmw_delete
…y index might have changed while being read
…d struct to reflect that is just a status being tracked
…til the operation is not commited
…ot try to hold twice the same lock if a read is being carried out in an rmw operation meanwhile ensuring that the entry index will be purged and/or the hashtable bucket emptied if necessary
…t/expected, and add a few tests to better cover the parameters combinations in SET
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 78.75% 79.02% +0.27%
==========================================
Files 104 105 +1
Lines 6583 6749 +166
==========================================
+ Hits 5184 5333 +149
- Misses 1399 1416 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 4 groups of changes:
This PR closes the issue #173