Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scan command #211

Merged
merged 6 commits into from
Aug 31, 2022
Merged

Implement scan command #211

merged 6 commits into from
Aug 31, 2022

Conversation

danielealbano
Copy link
Owner

This PR implements the redis SCAN command that operates on the key space and let a client to iterate over all the available keys that were present at the time when the (single) SCAN commands were issued.

The PR includes a code refactoring of the storage_db_op_get_keys operation and updates the KEYS command to use the new interface.

Tests are included in the PR together with some minor style fixes.

@danielealbano danielealbano added the enhancement New feature or request label Aug 31, 2022
@danielealbano danielealbano added this to the v0.2 milestone Aug 31, 2022
@danielealbano danielealbano self-assigned this Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 80.35% // Head: 80.42% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (d14590e) compared to base (00b8b28).
Patch coverage: 91.67% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   80.35%   80.42%   +0.06%     
==========================================
  Files         135      136       +1     
  Lines        8062     8114      +52     
==========================================
+ Hits         6478     6525      +47     
- Misses       1584     1589       +5     
Impacted Files Coverage Δ
...c/module/redis/command/module_redis_command_scan.c 89.19% <89.19%> (ø)
src/storage/db/storage_db.c 64.69% <94.44%> (+0.64%) ⬆️
.../data_structures/hashtable/mcmp/hashtable_op_rmw.c 98.28% <100.00%> (ø)
...c/module/redis/command/module_redis_command_keys.c 88.89% <100.00%> (+1.39%) ⬆️
src/utils_string.c 58.70% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielealbano danielealbano merged commit 702ce4c into main Aug 31, 2022
@danielealbano danielealbano deleted the implement_scan_command branch August 31, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant