Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement substr command #212

Merged
merged 2 commits into from
Aug 31, 2022
Merged

Implement substr command #212

merged 2 commits into from
Aug 31, 2022

Conversation

danielealbano
Copy link
Owner

The PR implements the SUBSTR command, although it's deprecated it's still available.

The SUBSTR command is a clone of the GETRANGE command, tests have been duplicated and adapted as needed.

@danielealbano danielealbano added the enhancement New feature or request label Aug 31, 2022
@danielealbano danielealbano self-assigned this Aug 31, 2022
@danielealbano danielealbano added this to In Progress in cachegrand via automation Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 80.35% // Head: 80.40% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (dc947e8) compared to base (00b8b28).
Patch coverage: 93.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   80.35%   80.40%   +0.05%     
==========================================
  Files         135      136       +1     
  Lines        8062     8091      +29     
==========================================
+ Hits         6478     6505      +27     
- Misses       1584     1586       +2     
Impacted Files Coverage Δ
...module/redis/command/module_redis_command_substr.c 93.10% <93.10%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielealbano danielealbano merged commit 11239a4 into main Aug 31, 2022
cachegrand automation moved this from In Progress to Completed Aug 31, 2022
@danielealbano danielealbano deleted the implement_substr_command branch August 31, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
cachegrand
  
Completed
Development

Successfully merging this pull request may close these issues.

None yet

1 participant