Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement append command #213

Merged
merged 4 commits into from
Aug 31, 2022
Merged

Implement append command #213

merged 4 commits into from
Aug 31, 2022

Conversation

danielealbano
Copy link
Owner

This PR implements the APPEND command and the required tests for validation

It also contains a number of fixes and improvements for the SETRANGE tests.

@danielealbano danielealbano added bug Something isn't working enhancement New feature or request labels Aug 31, 2022
@danielealbano danielealbano added this to the v0.2 milestone Aug 31, 2022
@danielealbano danielealbano self-assigned this Aug 31, 2022
@danielealbano danielealbano added this to In Progress in cachegrand via automation Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 80.35% // Head: 80.44% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (56bf74b) compared to base (00b8b28).
Patch coverage: 78.21% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   80.35%   80.44%   +0.09%     
==========================================
  Files         135      138       +3     
  Lines        8062     8221     +159     
==========================================
+ Hits         6478     6613     +135     
- Misses       1584     1608      +24     
Impacted Files Coverage Δ
...module/redis/command/module_redis_command_append.c 78.21% <78.21%> (ø)
src/utils_string.c 58.70% <0.00%> (ø)
...module/redis/command/module_redis_command_substr.c 93.10% <0.00%> (ø)
...c/module/redis/command/module_redis_command_scan.c 89.19% <0.00%> (ø)
src/storage/db/storage_db.c 64.69% <0.00%> (+0.64%) ⬆️
...c/module/redis/command/module_redis_command_keys.c 88.89% <0.00%> (+1.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielealbano danielealbano merged commit 34e010b into main Aug 31, 2022
cachegrand automation moved this from In Progress to Completed Aug 31, 2022
@danielealbano danielealbano deleted the implement_append_command branch August 31, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
cachegrand
  
Completed
Development

Successfully merging this pull request may close these issues.

None yet

1 participant