Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AUTH and HELLO implementation to abstract away all the business logic #397

Merged
merged 1 commit into from
May 10, 2023

Conversation

danielealbano
Copy link
Owner

This PR reorganise the AUTH and HELLO command to abstract away into helpers all the business logic.

@danielealbano danielealbano added the enhancement New feature or request label May 10, 2023
@danielealbano danielealbano added this to the v0.4 milestone May 10, 2023
@danielealbano danielealbano self-assigned this May 10, 2023
@danielealbano danielealbano added this to In Progress in cachegrand via automation May 10, 2023
@danielealbano danielealbano modified the milestones: v0.4, v0.3 May 10, 2023
@danielealbano danielealbano enabled auto-merge (squash) May 10, 2023 19:23
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 83.64% and project coverage change: -0.01 ⚠️

Comparison is base (d9c82ae) 78.27% compared to head (149627b) 78.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   78.27%   78.26%   -0.01%     
==========================================
  Files         192      193       +1     
  Lines       13203    13231      +28     
==========================================
+ Hits        10334    10354      +20     
- Misses       2869     2877       +8     
Flag Coverage Δ
unittests 78.26% <83.64%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/module/redis/command/module_redis_command_auth.c 100.00% <ø> (ø)
...ommand/helpers/module_redis_command_helper_hello.c 80.22% <80.22%> (ø)
...command/helpers/module_redis_command_helper_auth.c 88.89% <100.00%> (+1.79%) ⬆️
.../module/redis/command/module_redis_command_hello.c 100.00% <100.00%> (+21.95%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielealbano danielealbano merged commit ae11757 into main May 10, 2023
2 checks passed
cachegrand automation moved this from In Progress to Completed May 10, 2023
@danielealbano danielealbano deleted the feat-refactor-hello-auth branch May 10, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
cachegrand
  
Completed
Development

Successfully merging this pull request may close these issues.

None yet

1 participant