Further reduce the aggressiveness of the keys eviction fiber #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielealbano
deleted the
bug-further-reduce-keys-eviction-fiber-aggressiviness
branch
Valkyrie00
added a commit
that referenced
this pull request
Jun 1, 2023
* main: (27 commits) Bug fix aarch64 build issue (#427) Further increase to 7.5s the tls receive before the handshake is completed (#426) Bug fix tls redis benchmark (#425) Fix tls handshake wait blocks listener accept (#424) Disable required authentication by default (#423) Distinguish between failures during prep or during processing (#422) Further reduce the aggressiveness of the keys eviction fiber (#421) Bug catch negative counters (#420) Implement additional test for disabled commands (#419) Reduce the aggressiveness of the keys eviction fiber (#418) Impl commands disable (#417) Fix hashtable locking (#415) The entry index can be deleted once set in the hashtable (#416) Ensure that the hashtable for the redis commands is large enough (#414) Implement PING inline tests (#413) Add support for the PING command over the inline protocol (#412) Zero memory when upsize args list (#411) Implement Redis config get command (#410) Enforce TTL (#409) Fix the Redis module doc header (#408) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further reduce the aggressiveness of the keys eviction fiber running only once every 5ms instead of every 2ms.
This will not really impact significantly the amount of keys to be purged as the fiber does up to 100 loops to try to reduce the amount of inserted keys, infact the fiber will still free keys for up to 100 iterations for each run and will free 8 keys for each iteration, therefore in a second it might still free 100000 keys per thread, which is plenty without impacting on the performances.