Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign workflow instance name/identifier #156

Merged
merged 3 commits into from
Jul 22, 2018
Merged

Assign workflow instance name/identifier #156

merged 3 commits into from
Jul 22, 2018

Conversation

Miggleness
Copy link
Contributor

@Miggleness Miggleness commented Jul 10, 2018 •
edited
Loading

This PR is to address #153 which exposes the WorkflowInstance's 'Reference' property.

Notes:

  • A number of unit tests are failing from my end prior to change, I didn't bother with those. I'm using Rider 2018.1 on Mac.
  • Regarding placement of "Reference" argument in StartWorkflow(). The current placement feels awkward, but it sets up for slightly better compatibility. Preferably, the sequence will be (id, version, reference, data)
  • I'm considering updating model builder to index 'Reference'. But then, probably better to let the end users decide on that.

danielgerlag
danielgerlag approved these changes Jul 15, 2018
View reviewed changes
Copy link
Owner

@danielgerlag danielgerlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Could you also increment the version number?

src/samples/WorkflowCore.Sample02/Program.cs Outdated
@@ -21,7 +21,7 @@ public static void Main(string[] args)
host.RegisterWorkflow<SimpleDecisionWorkflow>();
host.Start();

host.StartWorkflow("Simple Decision Workflow", 1, null);
host.StartWorkflow("Simple Decision Workflow", 1, null, null);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we simplify all the samples to just use host.StartWorkflow(name)?

@Miggleness
Copy link
Contributor Author

done :)

Any chance you're upgrading the samples to dotnet core 2.1.1? For some odd reason, my Mac won't run the 1.x SDK installers.

@danielgerlag danielgerlag merged commit 894398a into danielgerlag:master Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielgerlag danielgerlag danielgerlag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Miggleness @danielgerlag