Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2

Merged
3 commits merged into from
Jan 8, 2021
Merged

Update README.md #2

3 commits merged into from
Jan 8, 2021

Conversation

dantiodev
Copy link
Owner

Slightly improve phrasing/structuring

Slightly improve phrasing/structuring
@ghost
Copy link

ghost commented Jan 8, 2021

I think "by you" is probably necessary. I essentially copy pasted this from the "5. Submission of Contributions" section in the Apache License. IANAL, so I don't know what's the proper wordology here.

@ghost
Copy link

ghost commented Jan 8, 2021

Yeah generally I think the "you" emphasis is a bit weird but makes things clearer and it may have some subtle differences in legal interpretations. I'd prefer keeping it as is.

Readded "by you"
@dantiodev
Copy link
Owner Author

Readded. I agree, better to be safe rather than sorry.

@ghost
Copy link

ghost commented Jan 8, 2021

Nit: also re-add the "you" in the first part too. Presumably, the current phrasing could let someone else make the explicit notice, not the actual contributor themselves.

Readded the original explicit statement for added context
@dantiodev
Copy link
Owner Author

That should be all, yes?

@ghost ghost merged commit 8eb06b9 into main Jan 8, 2021
@dantiodev dantiodev deleted the dantiodev-patch-1 branch January 8, 2021 19:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant