Fix build for new upstream format #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: e76e503 This is a development version and should only be installed for testing purposes. (by dappnodebot/build-action) |
pablomendezroyo
approved these changes
Jun 14, 2024
dappnodedev
added a commit
that referenced
this pull request
Jun 26, 2024
commit cfbdb0f Author: dappnodedev <diego@dappnode.io> Date: Tue Jun 18 17:28:29 2024 +0200 0.3.24 commit 2ff654a Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Tue Jun 18 17:21:54 2024 +0200 Bugfix: Create Github releases (#434) * Bump octokit version * Fix Github release creation * Update all github requests * Do not upload release assets * Use octokit.rest * Improve Github error handling commit cc60a42 Author: dappnodedev <diego@dappnode.io> Date: Fri Jun 14 16:17:01 2024 +0200 0.3.23 commit 93ebd23 Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Fri Jun 14 16:05:05 2024 +0200 Fix build for new upstream format (#433) * Fix build for new upstream format * Compare with string status 404 (not number) * Update remote IPFS API for tests
dappnodedev
added a commit
that referenced
this pull request
Jul 8, 2024
* Update octokit * Handle multi-variant packages for publish * Update tests * Fix tests * Remove unused code * Fix upstream version * Increase version for variants * Update flags description * Renamed file to file name for content-hash * Remove comment * Squashed commit of the following: commit cfbdb0f Author: dappnodedev <diego@dappnode.io> Date: Tue Jun 18 17:28:29 2024 +0200 0.3.24 commit 2ff654a Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Tue Jun 18 17:21:54 2024 +0200 Bugfix: Create Github releases (#434) * Bump octokit version * Fix Github release creation * Update all github requests * Do not upload release assets * Use octokit.rest * Improve Github error handling commit cc60a42 Author: dappnodedev <diego@dappnode.io> Date: Fri Jun 14 16:17:01 2024 +0200 0.3.23 commit 93ebd23 Author: dappnodedev <144998261+dappnodedev@users.noreply.github.com> Date: Fri Jun 14 16:05:05 2024 +0200 Fix build for new upstream format (#433) * Fix build for new upstream format * Compare with string status 404 (not number) * Update remote IPFS API for tests * Fix BuildVariantsMap import * Add "NoThrow" to the generate release notes function * Copy prometheus targets to release dir * Handle variant dir not existent * Declare var outside switch * SImplify release body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building packages that include the new upstream format in their manifest (https://github.com/dappnode/DAppNodePackage-holesky-obol/blob/374c1d0d6aebbbf38d96d53804e5de1b401d3f65/dappnode_package.json#L4) fail with this error:
https://github.com/dappnode/DAppNodePackage-DMS/actions/runs/9514324171/job/26226282057#step:3:25
This PR fixes it