Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PR check for docker login #565

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Remove PR check for docker login #565

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6ac6b1
remove PR check for docker login
tanvigour Mar 1, 2022
ab4afd7
remove PR trigger for the workflow to fix docker login issue
tanvigour Mar 1, 2022
59b8045
Merge branch 'master' into tanvi/branch
artursouza Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ on:
- v*
paths-ignore:
- '**.md'
pull_request:
branches:
- master
- release-*
workflow_dispatch:
jobs:
build:
Expand Down Expand Up @@ -67,11 +63,9 @@ jobs:
popd
done
- name: docker login
if: github.event_name != 'pull_request'
run: |
docker login -u ${{ secrets.DOCKER_REGISTRY_ID }} -p ${{ secrets.DOCKER_REGISTRY_PASS }}
- name: publish image to dockerhub
if: github.event_name != 'pull_request'
run: |
SAMPLE_LIST=(hello-kubernetes distributed-calculator pub-sub bindings observability secretstore)

Expand All @@ -93,7 +87,6 @@ jobs:
- name: Parse release version and set REL_VERSION
run: python ./.github/scripts/get_release_version.py
- name: create docker manifest
if: github.event_name != 'pull_request'
run: |
SAMPLE_LIST=(hello-kubernetes distributed-calculator pub-sub bindings observability secretstore)

Expand All @@ -104,11 +97,9 @@ jobs:
popd
done
- name: docker login
if: github.event_name != 'pull_request'
run: |
docker login -u ${{ secrets.DOCKER_REGISTRY_ID }} -p ${{ secrets.DOCKER_REGISTRY_PASS }}
- name: publish manifest to dockerhub
if: github.event_name != 'pull_request'
run: |
SAMPLE_LIST=(hello-kubernetes distributed-calculator pub-sub bindings observability secretstore)

Expand Down