Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.pubsub] revert change to fix pubsub sample #85

Merged
merged 1 commit into from
Oct 25, 2019
Merged

[5.pubsub] revert change to fix pubsub sample #85

merged 1 commit into from
Oct 25, 2019

Conversation

youngbupark
Copy link
Contributor

@youngbupark youngbupark commented Oct 25, 2019 •
edited
Loading

Description

Problem: the recent change accepts only application/json content-type so that node app doesn't not get the cloud event request from Dapr runtime.

  • Revert change to fix pubsub sample.

Issue reference

#79

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The sample code compiles correctly
  • You've tested new builds of the sample if you changed sample code
  • You've updated the sample's README if necessary

@youngbupark youngbupark merged commit 12e3ae9 into master Oct 25, 2019
@youngbupark youngbupark deleted the youngp/fix-pubsub-sample branch October 25, 2019 00:38
@youngbupark youngbupark mentioned this pull request Oct 25, 2019
Closed
@ryanvolum ryanvolum mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shalabhms shalabhms shalabhms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngbupark @shalabhms