Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update German translation #406

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

tiltX
Copy link
Contributor

@tiltX tiltX commented Mar 6, 2021

This updates a few strings that currently exist in the locale files. It doesn't add translations to the new English strings that have been added or renamed since 2.0.8 was released.

Is there a workflow for those? It seems to me as if the missing strings are generated before each release. Is this an automated process or are you using certain tools/scripts? I'm asking because I'd like to tackle those new strings as well, but it would be a bit of a chore to find all missing keys in the *.de.text files.

@darbyjohnston
Copy link
Owner

Hi, sorry for the delay and thanks for the translation fixes!

The workflow is not great right now, basically I add the text in English and then periodically run a script which converts the English to other languages using a machine translation service. All of the fixes have been from volunteers like yourself who spot the bad translations and then submit patches. There's an issue for improving the workflow here:
#181

Maybe a small change that could make things easier is if I added an extra field in the JSON files that shows whether a translation has been reviewed or not. That way the new text and machine translations would be easy to spot and fix if necessary. I could also freeze any English text changes a few weeks ahead of a release to give people a chance to make corrections for the other languages.

@darbyjohnston darbyjohnston merged commit 848a533 into darbyjohnston:master Mar 10, 2021
@tiltX tiltX deleted the locale_de branch March 13, 2021 10:33
@tiltX
Copy link
Contributor Author

tiltX commented Mar 13, 2021

I think such a string freeze would be great! I don't know if a field in the json file would be of much use (at least to me, when checking strings) because there's always git's commit history to see if/what has changed.

There's one thing though that I felt made my work more difficult: you have renamed some keys in the json files but intstead of renaming them in each locale the strings have disappeared completely. I can compare English and German files side-by-side to easily see what's missing, but it's harder to find out what the original translation was (or if the missing key is in fact a new string).

long story short: I think it would be great if renamed keys in the English files could also be renamed in the locales.

@darbyjohnston
Copy link
Owner

Hi sorry about the deleted keys, I'll be more careful about that in the future. Whenever I changed a key or translation I was in the habit of deleting them from the other language files, but if just the key changes that's not necessary and I can rename them instead of deleting them. If the text changes it seems like they should be deleted, otherwise the translated text could be totally different from the English.

I can also start using the GitHub "Discussions" feature to announce new releases and string freezes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants