Fix std::string corruption caused by memset a non-POD variable

Fixes #4
darksylinc · Oct 25, 2020 · a8f4794 · a8f4794
1 parent be41953
commit a8f4794
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/include/CmdLineParams.h b/include/CmdLineParams.h
@@ -26,9 +26,11 @@ namespace Codec
 
 struct CmdLineParams
 {
-	uint8_t quality;
-	bool dither;
-	bool usingRenderDoc;
+	uint8_t      quality;
+	bool         dither;
+	bool         usingRenderDoc;
 	Codec::Codec codec;
-	std::string filename[2];
+	std::string  filename[2];
+
+	CmdLineParams() : quality( 0 ), dither( false ), usingRenderDoc( false ), codec( Codec::etc1 ) {}
 };
diff --git a/src/main.cpp b/src/main.cpp
@@ -162,7 +162,6 @@ void saveToDisk( T &encoder, const CmdLineParams params )
 int main( int nargs, char *const argv[] )
 {
 	CmdLineParams params;
-	memset( &params, 0, sizeof( params ) );
 	params.quality = 2;
 
 	if( !parseCmdLine( nargs, argv, params ) )