-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the BC3 shaders compatible with GLSL ES version 310 #12
base: master
Are you sure you want to change the base?
Conversation
|
ffab5ee
to
79fb671
Compare
Updated WRT to Vulkan compatibility, we shouldn't need to change the version directive right? AFAICT, One downside I've noticed with the PR's usage of rg32 and rgba16 (c2f0e02) is that it'd require a Vulkan app to set |
Increases compatibility with GLSL ES version 310.
79fb671
to
834c79d
Compare
This is a better fit for indexing and for using as a boolean. While we're here, avoid implicit data type conversions with the elements in the uniform. This increases compatibility with GLSL ES version 310.
Increases compatibility with GLSL ES version 310.
Increases compatibility with GLSL ES version 310.
Increases compatibility with GLSL ES version 310.
To be used in the following commit.
Increases compatibility with GLSL ES version 310. The ARB_shader_image_load_store extension says, For textures allocated by the GL, an image unit format is compatible with a texture internal format if they match by size. The textures were allocated by the GL implementation, so this format substitution is safe to do.
The shaders are compatible with GLSL ES version 310. Require the GL_ARB_ES3_1_compatibility extension and change the version directives accordingly so that we get validation from the GL implementation.
834c79d
to
38a46c2
Compare
This is based on a collection of changes I had to make when I tried to compile these shaders in gles31 apps. Please let me know what you think.