Skip to content

Commit

Permalink
removed unused code
Browse files Browse the repository at this point in the history
  • Loading branch information
lsbardel committed Nov 27, 2017
1 parent 27ab3e6 commit 09f182b
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 23 deletions.
8 changes: 0 additions & 8 deletions extensions/lib/events.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,6 @@ cdef class EventHandler:
if event.name in events:
event.bind(events[event.name])

cpdef reset_event(self, str name):
cdef dict events = self.events()
cdef Event event;

if name in events:
event = events[name]
events[name] = Event(name, self, 1 if event.onetime() else 0)

cpdef copy_many_times_events(self, EventHandler other):
'''Copy :ref:`many times events <many-times-event>` from ``other``.
Expand Down
6 changes: 0 additions & 6 deletions pulsar/apps/http/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -646,12 +646,6 @@ def on_body(self, body):
else:
self.content += body

def recv_body(self):
content = self.content
if content:
self.content = b''
return content or b''

def on_message_complete(self):
self.producer.maybe_decompress(self)
self.fire_event('post_request')
Expand Down
15 changes: 6 additions & 9 deletions pulsar/utils/pylib/events.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,16 +128,19 @@ def events(self):
return self._events

def event(self, name):
'''Returns the :class:`Event` at ``name``.
"""Returns the :class:`Event` at ``name``.
If no event is registered for ``name`` returns nothing.
'''
If no event is registered for ``name`` creates a new :class:`Event`
object and returns it.
"""
events = self.events()
if name not in events:
events[name] = Event(name, self, 0)
return events[name]

def fire_event(self, name, exc=None, data=None):
"""Fire event at ``name`` if it is registered
"""
if self._events and name in self._events:
self._events[name].fire(exc=exc, data=data)

Expand All @@ -150,12 +153,6 @@ def bind_events(self, events):
if event.name in events:
event.bind(events[event.name])

def reset_event(self, name):
events = self.events()
if name in events:
event = events[name]
events[name] = Event(name, self, 1 if event.onetime() else 0)

def copy_many_times_events(self, other):
'''Copy :ref:`many times events <many-times-event>` from ``other``.
Expand Down
42 changes: 42 additions & 0 deletions tests/bench/test_events.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
import unittest

from pulsar.utils.pylib.events import EventHandler as PyEventHandler
from pulsar.api import EventHandler


class TestPythonCode(unittest.TestCase):
__benchmark__ = True
__number__ = 10000

@classmethod
async def setUpClass(cls):
cls.hnd = EventHandler()
cls.py_hnd = PyEventHandler()
cls.hnd.event('bang').bind(cls.bang)
cls.py_hnd.event('bang').bind(cls.bang)

def test_bind(self):
self.hnd.event('foo').bind(self.foo)

def test_fire(self):
self.hnd.fire_event('bang')

def test_fire_data(self):
self.hnd.fire_event('bang', data=self)

def test_bind_py(self):
self.py_hnd.event('foo').bind(self.foo)

def test_fire_py(self):
self.py_hnd.fire_event('bang')

def test_fire_data_py(self):
self.py_hnd.fire_event('bang', data=self)

@classmethod
def foo(cls, o):
pass

@classmethod
def bang(cls, o, data=None):
pass

0 comments on commit 09f182b

Please sign in to comment.