Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for extension types and subtype relations to Object #2342

Closed
sgrekhov opened this issue Nov 1, 2023 · 1 comment
Closed

Add tests for extension types and subtype relations to Object #2342

sgrekhov opened this issue Nov 1, 2023 · 1 comment
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Nov 1, 2023

Add tests according to the dart-lang/language#3434
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Nov 1, 2023
@sgrekhov sgrekhov self-assigned this Nov 1, 2023
@sgrekhov sgrekhov mentioned this issue Nov 8, 2023
Merged
@eernstg
Copy link
Member

eernstg commented Nov 8, 2023

Note that apart from adding new tests, some existing tests updated in #2360 need updates in their @assertion and/or @description sections.

sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 20, 2023
@sgrekhov
dart-lang#2342. Update nullability tests according to the new rules
d8f07c0
eernstg pushed a commit that referenced this issue Nov 21, 2023
@sgrekhov
#2342. Update nullability tests according to the new rules (#2385)
55f9ad0 
Update nullability tests according to the new rules
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 24, 2023
@sgrekhov @athomas
[co19] Roll co19 to 85c868a325bc92f4e743958077ad0ad2eb58c81f
2534859 
2023-11-23 athom@google.com Merge pull request dart-lang/co19#2395 from dart-lang/merge-pre-nnbd
2023-11-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2390. Fix tests according to the new method/setter rules (dart-lang/co19#2392)
2023-11-23 sgrekhov22@gmail.com Fixes dart-lang/co19#2388. Add tests for the new method/setter rules. Update assertions (dart-lang/co19#2393)
2023-11-23 athom@google.com Merge remote-tracking branch 'origin/pre-nnbd' into master
2023-11-22 sgrekhov22@gmail.com Fixes dart-lang/co19#2389. Add additional error expectation for analyzer (dart-lang/co19#2391)
2023-11-21 sgrekhov22@gmail.com dart-lang/co19#2342. Update nullability tests according to the new rules (dart-lang/co19#2385)
2023-11-21 sgrekhov22@gmail.com Fixes dart-lang/co19#2384. Fix not well-bound extension types. Add function-type dynamic test (dart-lang/co19#2387)

Change-Id: Ic3848f6f39fd42b01bfed5feac3d922c6f5a53d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/338120
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @eernstg