#2142. Add syntax tests #2148
Merged
#2142. Add syntax tests #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Jul 25, 2023
There was a problem hiding this comment.
Looks good! Just one thing I believe must be changed: ET.new(42) is not an error when ET declares a constructor (a primary constructor in this case, but any constructor would do) whose name is ET.
I also mentioned a couple of places where a test will need to be adjusted in the future if we adopt the primary constructor proposal (in its current form or something that isn't too different). I don't know what's the best approach; perhaps we can just ignore this situation and rely on our ability to rediscover it when needed? .. another approach could be to put a TODO comment saying that "when we have primary constructors, this needs to change as follows: ...". WDYT?
sgrekhov
commented
Jul 25, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 31, 2023
2023-07-28 sgrekhov22@gmail.com dart-lang/co19#2142. Fix typo (dart-lang/co19#2155) 2023-07-26 sgrekhov22@gmail.com dart-lang/co19#2149. Fix new errors due to changes with the constant evaluator (dart-lang/co19#2152) 2023-07-26 sgrekhov22@gmail.com dart-lang/co19#2145. Add more tests for Variable (dart-lang/co19#2146) 2023-07-25 sgrekhov22@gmail.com dart-lang/co19#2142. Add syntax tests (dart-lang/co19#2148) Change-Id: I6ee222b74fc092d93a1b76d35d89a008a97056be Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316590 Commit-Queue: William Hesse <whesse@google.com> Reviewed-by: William Hesse <whesse@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that it's easier to add new etxtension types tests (which are, in fact, edited copies of inline classes tests) rather then rename and change inline classes ones. I'm going to go on this way and when there will be nothing more to copy and edit I'll delete Inline classes folder