#2142. Change static analysis inline class tests to be extension type tests. Part 1 #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion type tests. Part 1
…sion type tests. Part 1, more tests
chloestefantsova
requested changes
Jul 31, 2023
| /// } | ||
| /// It is then allowed to use V<T1, .. Ts> as a type. | ||
| /// It is then allowed to use V<T1, .. Tk> as a type. |
There was a problem hiding this comment.
Here and below: where does k from Tk come from?
There was a problem hiding this comment.
Assertion extended
Comment on lines
+18
to
+19
| typedef void Foo1(); | ||
| typedef Foo2 = int Function(int); |
There was a problem hiding this comment.
It would also be nice to have a test where the type following the implements keyword is a function type directly, not a type alias that expands into a function type.
sgrekhov
commented
Jul 31, 2023
| /// } | ||
| /// It is then allowed to use V<T1, .. Ts> as a type. | ||
| /// It is then allowed to use V<T1, .. Tk> as a type. |
There was a problem hiding this comment.
Assertion extended
Comment on lines
+18
to
+19
| typedef void Foo1(); | ||
| typedef Foo2 = int Function(int); |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 4, 2023
2023-08-03 sgrekhov22@gmail.com dart-lang/co19#2142. Rename and move static analysis extension type tests (dart-lang/co19#2164) 2023-08-03 sgrekhov22@gmail.com dart-lang/co19#2142. Add more static analysis inline class tests (dart-lang/co19#2163) 2023-08-02 sgrekhov22@gmail.com dart-lang/co19#2142. Turn static analysis inline classes tests to extension type tests. Part 2 (dart-lang/co19#2161) 2023-08-02 sgrekhov22@gmail.com dart-lang/co19#2142. Move dynamic semantics member invocation tests to Extension-types folder (dart-lang/co19#2156) 2023-08-02 sgrekhov22@gmail.com dart-lang/co19#2142. Change static analysis inline class tests to be extension type tests. Part 1 (dart-lang/co19#2157) 2023-08-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.11.0 to 3.12.0 (dart-lang/co19#2160) 2023-07-28 sgrekhov22@gmail.com dart-lang/co19#2142. Change dynamic semantics member invocation tests to be extension type tests (dart-lang/co19#2154) Change-Id: Icfb257200f9922971390c96bf8fb51093c4becfe Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/318060 Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.