Fixes #2925. Fix expected errors positions in grammar_A05_t01_lib.dart #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Oct 10, 2024
|
Thinking again: Wouldn't it be nice to have a comment at the location where we just had an error expectation comment? It should say something like // This is a syntax error, but the tools will recognize `library` above and omit
// all further analysis of this file, because it was expected to be a part file.
// Hence, the syntax error (and any other errors in this file) will not be
// reported.I just landed this one, so that would be a new PR. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 11, 2024
2024-10-10 sgrekhov22@gmail.com dart-lang/co19#2925. Add comment explaining why the syntax error is not reported in grammar_A05_t01_lib.dart (dart-lang/co19#2931) 2024-10-10 sgrekhov22@gmail.com Fixes dart-lang/co19#2925. Fix expected errors positions in grammar_A05_t01_lib.dart (dart-lang/co19#2929) 2024-10-09 sgrekhov22@gmail.com dart-lang/co19#2923. More tests for import and export library with the same URI. (dart-lang/co19#2928) 2024-10-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2926. Remove unnecessary error expectation from grammar_A04_t01.dart (dart-lang/co19#2927) 2024-10-08 sgrekhov22@gmail.com dart-lang/co19#2923. Add tests for import/exports with the same URI (dart-lang/co19#2924) 2024-10-07 sgrekhov22@gmail.com dart-lang/co19#2825. Fix dotted.library.name syntax in `part of` directive (dart-lang/co19#2922) 2024-10-04 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting enum values test. (dart-lang/co19#2921) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I81902e4e4eac8a0b0ffd3f20d957aa9bfcc2cdc5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389700 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.