Remove the old CLI options and executables. #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the `dart format` command was added to the core Dart SDK, users accessed the formatter by running a separate `dartfmt` executable that was included with the Dart SDK. That executable had a different CLI interface. For example, you had to pass `-w` to get it to overwrite files and if you passed no arguments at all, it silently sat there waiting for input on stdin. When we added `dart format`, we took that opportunity to revamp the CLI options. However, the dart_style package still exposed an executable with the old CLI. If you ran `dart pub global activate dart_style`, this would give you a `dartfmt` (and `dartformat`) executable with the old CLI options. Now that almost everyone is using `dart format`, we have removed the old CLI and the old package executables. You can still run the formatter on the CLI through the package (for example, if you want to use a particular version of dart_style instead of the one bundled with your Dart SDK). But it now uses the exact same CLI options and arguments as the `dart format` command. You can invoke it with `dart run dart_style:format <args...>`.
natebosch
approved these changes
Sep 11, 2024
|
This actually shouldn't affect the SDK at all. The SDK is already using newer CLI and the newer |
25 tasks
# Conflicts: # CHANGELOG.md # bin/format.dart # lib/src/cli/options.dart # test/cli_test.dart # test/command_line_test.dart
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the
dart formatcommand was added to the core Dart SDK, users accessed the formatter by running a separatedartfmtexecutable that was included with the Dart SDK. That executable had a different CLI interface. For example, you had to pass-wto get it to overwrite files and if you passed no arguments at all, it silently sat there waiting for input on stdin. When we addeddart format, we took that opportunity to revamp the CLI options.However, the dart_style package still exposed an executable with the old CLI. If you ran
dart pub global activate dart_style, this would give you adartfmt(anddartformat) executable with the old CLI options. Now that almost everyone is usingdart format, we have removed the old CLI and the old package executables.You can still run the formatter on the CLI through the package (for example, if you want to use a particular version of dart_style instead of the one bundled with your Dart SDK). But it now uses the exact same CLI options and arguments as the
dart formatcommand. You can invoke it withdart run dart_style:format <args...>.