Make PackageGraph.allLibraries private #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @dart-lang/analyzer-team |
bwilkerson
approved these changes
Jun 20, 2024
srawlins
force-pushed
the
private-all-libraries
branch
from
853a591
to
8405ab4
Compare
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 24, 2024
…est_descriptor, test_process, tools, typed_data, webdev, yaml Revisions updated by `dart tools/rev_sdk_deps.dart`. csslib (https://github.com/dart-lang/csslib/compare/23c314b..b70fef2): b70fef2 2024-06-20 Kevin Moore Update and fix lints, bump min SDK to Dart 3.1 (dart-lang/csslib#204) dartdoc (https://github.com/dart-lang/dartdoc/compare/6330a13..88df88c): 88df88c9 2024-06-21 Sam Rawlins Remove the unnecessary Privacy mixin (dart-lang/dartdoc#3794) d050cb44 2024-06-20 Sam Rawlins Make PackageGraph.allLibraries private (dart-lang/dartdoc#3792) 7c559d41 2024-06-20 Sam Rawlins Simplify Library.allModelElements (dart-lang/dartdoc#3793) http (https://github.com/dart-lang/http/compare/8c325b9..4d8e7ef): 4d8e7ef 2024-06-24 Brian Quinlan Add a note saying that we only create a single `Client`. (dart-lang/http#1234) pool (https://github.com/dart-lang/pool/compare/88e4636..832c5ab): 832c5ab 2024-06-21 Kevin Moore update lints, require Dart 3.4 (dart-lang/pool#89) d107269 2024-06-20 Kevin Moore blast_repo fixes (dart-lang/pool#88) pub_semver (https://github.com/dart-lang/pub_semver/compare/a9025f3..dfcad38): dfcad38 2024-06-20 Kevin Moore bump lints and SDK dep, test wasm (dart-lang/pub_semver#105) string_scanner (https://github.com/dart-lang/string_scanner/compare/7b37c1b..e1cab8f): e1cab8f 2024-06-20 Kevin Moore update lints, require Dart 3.1 (dart-lang/string_scanner#76) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/b23d7cc..2f19400): 2f19400 2024-06-20 Kevin Moore update lints (dart-lang/test_descriptor#68) test_process (https://github.com/dart-lang/test_process/compare/862eaf3..a7ca20b): a7ca20b 2024-06-21 Kevin Moore update lints (dart-lang/test_process#60) tools (https://github.com/dart-lang/tools/compare/4321aec..e660a68): e660a68 2024-06-24 Kevin Moore Don't collect coverage on Windows (dart-lang/tools#276) typed_data (https://github.com/dart-lang/typed_data/compare/d14f965..8529929): 8529929 2024-06-21 Kevin Moore update lints, require Dart 3.1 (dart-lang/typed_data#90) c90e624 2024-06-20 Kevin Moore blast_repo fixes (dart-lang/typed_data#89) webdev (https://github.com/dart-lang/webdev/compare/eccc7d8..c566112): c5661125 2024-06-24 Kevin Moore Drop use of deprecated APIs, bump min SDK and other dependencies (dart-lang/webdev#2449) yaml (https://github.com/dart-lang/yaml/compare/7873b3f..4cf24ca): 4cf24ca 2024-06-20 Kevin Moore update lints, require Dart 3.4 (dart-lang/yaml#167) 7018ac8 2024-06-20 Kevin Moore blast_repo fixes (dart-lang/yaml#166) Change-Id: I04c6238514cb46818c3f59760e401d371e4d1ae4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372841 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this maybe used to be used in the ModelElement or the Library classes, but now it can be made private (with some tidying in the tests).
This makes the code more understandable (what parts of PackageGraph are necessary for other code?), safer, and allows more static analysis (is this field ever used? can it be made final?).
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.