Skip to content

Commit

Permalink
observatory: Ignore new static Warning
Browse files Browse the repository at this point in the history
There are two spots where a nullable value is passed to a non-nullable
Future.value call, or a non-nullable Completer.complete call. In the
interest of not making any functional change, I'm just ignoring this
new code.

```
warning - lib/src/service/object.dart:870:29 - 'Future<Isolate>.value' shouldn't be called with an argument of nullable type 'Isolate?'. Try passing a non-null argument. - nullable_argument_to_non_null_type
warning - lib/src/service/object.dart:1559:29 - 'Future<Class>.value' shouldn't be called with an argument of nullable type 'Class?'. Try passing a non-null argument. - nullable_argument_to_non_null_type
```

Related to #53253

TEST=N/A

Change-Id: I091990975a1f2b927e007564b6ca0658c6a34c20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324762
Reviewed-by: Ben Konyi <bkonyi@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
  • Loading branch information
srawlins authored and Commit Queue committed Sep 18, 2023
1 parent 20a7d71 commit d3124b8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions runtime/observatory/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ analyzer:
dead_code: info
getter_not_subtype_setter_types: info
missing_enum_constant_in_switch: info
nullable_argument_to_non_null_type: info
unused_element: info
unused_field: info
unused_import: info
Expand Down

0 comments on commit d3124b8

Please sign in to comment.