CFE code should start passing a language version to dart_style

[munificent]

Greetings CFE team friends!

The formatter is moving to being language version aware. This means that when it's parsing some code, it needs to be told what language version to parse it as. The DartFormatter constructor now takes an optional parameter where you can pass in the language version. In a future version of dart_style, that parameter will become mandatory.

If you own code that uses dart_style as a library, you should update your code to pass in a language version. To migrate:

1. If this code is inside a package (as opposed to, say, the Dart core libraries), then update your constraint on dart_style to ^2.3.7. That's the version where the new parameter was added.

2. If you know the precise language version the code should be parsed as, then pass in that version (as an instance of the pub_semver package's Version class). This is what "real" tools should do.

   For simple one-off scripts and other utilities where precise behavior doesn't matter much, you can pass in DartFormatter.latestLanguageVersion to unconditionally parse the code as the latest language version that the formatter itself supports.

When the --tall-style experiment flag ships, the passed in language version will also be used to determine whether you get the current formatting style or the new "tall" style.

I did a search through the SDK, and the constructor calls that I think are relevant are:

~/dev/dart/sdk/pkg/front_end/benchmarks/patterns/generate_datatypes.dart:
   81:   String result = new DartFormatter().format(sb.toString());
  200:   String result = new DartFormatter().format(sb.toString());

~/dev/dart/sdk/pkg/front_end/test/parser_test_listener_creator.dart:
  117:   return new DartFormatter().format("$out");

~/dev/dart/sdk/pkg/front_end/test/parser_test_parser_creator.dart:
  118:   return new DartFormatter().format("$out");

~/dev/dart/sdk/pkg/front_end/test/fasta/textual_outline_suite.dart:
  160:           result = new DartFormatter(experimentFlags: experimentFlags)

~/dev/dart/sdk/pkg/front_end/tool/visitor_generator.dart:
   74:     result = new DartFormatter().format(result);

~/dev/dart/sdk/pkg/front_end/tool/_fasta/generate_experimental_flags.dart:
  182:   return new DartFormatter().format("$sb");
  216:   return new DartFormatter().format("$sb");
  528:   return new DartFormatter().format("$sb");

~/dev/dart/sdk/pkg/front_end/tool/_fasta/generate_messages.dart:
   31:       repoDir, (s) => new DartFormatter().format(s));

~/dev/dart/sdk/pkg/front_end/tool/_fasta/parser_ast_helper_creator.dart:
  122:   return new DartFormatter().format("$out");

Thank you!

[munificent]

I have a review out that addresses most of them: https://dart-review.googlesource.com/c/sdk/+/385341

The remaining one is textual_outline_suite.dart. That one probably should pass in a correct language version, and I don't know enough of the surrounding context to know how to get that.

[munificent]

OK, all that's left is:

~/dev/dart/sdk/pkg/front_end/test/fasta/textual_outline_suite.dart:
  160:           result = new DartFormatter(experimentFlags: experimentFlags)

[munificent]

This is done now.