Skip to content

Commit

Permalink
Handle initial message entirely within conditional
Browse files Browse the repository at this point in the history
Towards #2065

Refactor the current implementation to reduce complexity and keep the
code for the current behavior within the condition body. This will allow
the new behavior to be implemented in another branch of the conditional.

- Remove the `readyCompleter`. Don't start listening on the server
  channel until the frame communication is ready instead of eagerly
  listening and holding the messages callbacks awaiting the ready
  future.
- Keep only the long-term message channel in the stored subscriptions.
  We only expect a single message on the window channel from each frame,
  so we can cancel the subscription after we receive it.
  • Loading branch information
natebosch committed Jul 19, 2023
1 parent e76bffe commit 3c2702c
Show file tree
Hide file tree
Showing 2 changed files with 250 additions and 375 deletions.
Loading

0 comments on commit 3c2702c

Please sign in to comment.