Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strict-inference in analysis options #2095

Open
natebosch opened this issue Sep 20, 2023 · 1 comment
Open

Enable strict-inference in analysis options #2095

natebosch opened this issue Sep 20, 2023 · 1 comment

Comments

@natebosch
Copy link
Member

Try out the impact of this configuration. See dart-lang/lints#149
@natebosch
Copy link
Member Author

I'm going to separately land some of the places where this strictness caught real issues, then I'll open a PR with a larger diff which is mostly noise like <void> and we can discuss.

@natebosch natebosch mentioned this issue Sep 20, 2023
Merged
natebosch added a commit that referenced this issue Sep 20, 2023
@natebosch
Add types to Browser implementation url arguments
e21c708 
Towards #2095

Restrict to Uri arguments instead of the looser `dynamic` which in
practice allowed Strings (which were correctly formatted) or Uri
instances. Take Uri so the format is enforced and the `.toString()` can
be trusted.

Update (unused in practice) test args from dart-lang.org to dart.dev
natebosch added a commit that referenced this issue Sep 20, 2023
@natebosch
Tighten types in test utils
8bd0846 
Towards #2095

Use `Queue.of` to infer the collection type from the argument instead of
`Queue.from` which ignores the argument type.

Expand a bare `Function` to a full signature function type.
@natebosch natebosch mentioned this issue Sep 20, 2023
Merged
natebosch added a commit that referenced this issue Sep 25, 2023
@natebosch
Add types to Browser implementation url arguments (#2096)
9d99791 
Towards #2095

Restrict to Uri arguments instead of the looser `dynamic` which in
practice allowed Strings (which were correctly formatted) or Uri
instances. Take Uri so the format is enforced and the `.toString()` can
be trusted.

Update (unused in practice) test args from dart-lang.org to dart.dev
natebosch added a commit that referenced this issue Sep 25, 2023
@natebosch
Tighten types in test utils (#2097)
d3f4b36 
Towards #2095

Use `Queue.of` to infer the collection type from the argument instead of
`Queue.from` which ignores the argument type.

Expand a bare `Function` to a full signature function type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@natebosch