Add --fail-fast flag #2040
Merged
Add --fail-fast flag #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1841 Add a `--fail-fast` flag which stops running test cases after the first failure. - In the Engine, check for failed tests immediately after running them. When fast failures are enabled `close()` the engine after any failure. Cleanups teardowns and cleanups will run, and any concurrently running tests in other suits will finish, but no further tests will start. - Add the argument in `Configuration` and parse it with the args.
The "immediately" is misleading - when there are tests running concurrently they aren't interrupted.
jakemac53
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1841
Add a
--fail-fastflag which stops running test cases after the firstfailure.
when fast failures are enabled
close()the engine after any failure.teardowns and cleanups will run, and any concurrently running tests in
other suits will finish, but no further tests will start.
configurationand parse it with the args.