Expand dom interop to cover more uses #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `parent` getter on `window`. Use it to post a parent message instead of a private copy of the JS interop for the same. This had been using `@JS()` locally as a workaround for a bug in `dart:html`, and now that we aren't using `dart:html` anywhere in this code we can drop the extra copy. Expose the `source` field on `MessageEvent`. Use `js_util` to read the properties which may be missing to get to the `href` for the message. Trying to read the field through `dart:html` could throw, but after the migration to `@JS()` style interop the difference interfaces for the event source can be handled safely. Even though the host is no longer reading the href key from the messages they are still sent from the frame side for backwards compatibility with other host implementations. See #2065
jakemac53
approved these changes
Jul 19, 2023
natebosch
added a commit
that referenced
this pull request
Oct 13, 2023
Originally the href was added manually to the data to work around a `dart:html` limitation. A different workaround for the host side was implemented in #2066, but the frame side was not changed in the same commit to allow some cross-compatibility. Remove the final manual href field now that no host implementations would read it.
natebosch
added a commit
that referenced
this pull request
Oct 13, 2023
Originally the href was added manually to the data to work around a `dart:html` limitation. A different workaround for the host side was implemented in #2066, but the frame side was not changed in the same commit to allow some cross-compatibility. Remove the final manual href field now that no host implementations would read it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
parentgetter onwindow. Use it to post a parent messageinstead of a private copy of the JS interop for the same. This had been
using
@JS()locally as a workaround for a bug indart:html, and nowthat we aren't using
dart:htmlanywhere in this code we can drop theextra copy.
Expose the
sourcefield onMessageEvent. Usejs_utilto read theproperties which may be missing to get to the
hreffor the message.Trying to read the field through
dart:htmlcould throw, but after themigration to
@JS()style interop the difference interfaces for theevent source can be handled safely. Even though the host is no longer
reading the href key from the messages they are still sent from the
frame side for backwards compatibility with other host implementations.
See #2065