Add a silent reporter #2093
Merged
Add a silent reporter #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve some flaky tests by eliminating the reporter output as a potential race condition. Add a `hidden` flag to `ReporterDetails` since the reporter is not worth showing in the CLI usage help. Request the silent reporter for a test which is flaky due to interleaving of forwarded `stdout` with the reporter's output. During flakes the `hello` and the newline can come as separate events in the stream, so sometimes the newline is written following unexpected reporter content.
jakemac53
approved these changes
Sep 18, 2023
jakemac53
reviewed
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a flaky test by eliminating the reporter output as a
potential race condition.
Add a
hiddenflag toReporterDetailssince the reporter is not worthshowing in the CLI usage help. Request the silent reporter for a test
which is flaky due to interleaving of forwarded
stdoutwith thereporter's output. During flakes the
helloand the newline can come asseparate events in the stream, so sometimes the newline is written
following unexpected reporter content.