Fix last confirmed blocks #281

hackfisher · 2020-09-11T05:43:05Z

Closes Remove ConfirmedHeadersDoubleMap and ConfirmBlocksInCycle etc. #275
Closes verified's receipt should not limit the mmr_root block number to last confirmed #273
Closes ethereum-relay's should have genesis header or should able to set last confirmed block using root origin #276
Closes darwinia-ethereum-relay ropsten/mainet network type #272
Fix Tests
Migration

frame/bridge/ethereum/relay/src/lib.rs

AurevoirXavier · 2020-09-13T13:30:59Z

I can't find anywhere read/write ConfirmedDepth.

AurevoirXavier · 2020-09-13T13:39:36Z

I found some read/write first check last, fixed.

Read last avoid the unnecessary DB reads.
Write last guarantee no side effect on storage.

frame/bridge/ethereum/relay/src/lib.rs

hackfisher · 2020-09-13T14:22:17Z

I can't find anywhere read/write ConfirmedDepth.

ConfirmedDepth is in todo, will be implemented in later pr

Fix last confirmed blocks

45bb445

hackfisher requested review from AurevoirXavier and yanganto as code owners September 11, 2020 05:43

hackfisher added D1-runtime-migration labels Sep 11, 2020

hackfisher added 3 commits September 11, 2020 14:11

Fix checking

d376ba7

Fix tests

e320bdf

add ethereum network type support, fixed #272

1acf69f

hackfisher requested a review from clearloop as a code owner September 11, 2020 07:02

Merge branch 'master' into denny-refactor-confirmed-headers

b83622d

hackfisher removed the D2-remove-migration label Sep 11, 2020

clearloop reviewed Sep 12, 2020

View reviewed changes

frame/bridge/ethereum/relay/src/lib.rs Outdated Show resolved Hide resolved

clearloop added the B2-breaksapi label Sep 12, 2020

This was referenced Sep 12, 2020

Update the receipt API darwinia-network/shadow#85

Merged

Update the receipt API darwinia-network/dj#81

Merged

add reset_last_confirmed_header

c80d632

hackfisher requested a review from wuminzhe September 12, 2020 09:17

add migration

df375b3

hackfisher added the A0-pleasereview label Sep 12, 2020

hackfisher added 2 commits September 12, 2020 18:16

rename function

5022115

update types

172ac70

AurevoirXavier removed the A3-inprogress label Sep 13, 2020

remove: unused thing

c3aa3b5

AurevoirXavier assigned AurevoirXavier and unassigned AurevoirXavier Sep 13, 2020

AurevoirXavier marked this pull request as draft September 13, 2020 13:29

AurevoirXavier reviewed Sep 13, 2020

View reviewed changes

frame/bridge/ethereum/relay/src/lib.rs Outdated Show resolved Hide resolved

frame/bridge/ethereum/relay/src/lib.rs Show resolved Hide resolved

frame/bridge/ethereum/relay/src/lib.rs Outdated Show resolved Hide resolved

udpate: fix r/w & todo verify continuous

c8ff6e7

AurevoirXavier marked this pull request as ready for review September 13, 2020 16:29

AurevoirXavier added the E1-new-types label Sep 13, 2020

update: code owners

f8f6138

AurevoirXavier approved these changes Sep 14, 2020

View reviewed changes

hackfisher merged commit 23adbf7 into master Sep 14, 2020

AurevoirXavier removed the A0-pleasereview label Sep 14, 2020

AurevoirXavier mentioned this pull request Sep 14, 2020

Release 0.6.11 darwinia-network/darwinia#529

Merged

5 tasks

AurevoirXavier deleted the denny-refactor-confirmed-headers branch September 14, 2020 14:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix last confirmed blocks #281

Fix last confirmed blocks #281

hackfisher commented Sep 11, 2020 •

edited

Loading

AurevoirXavier commented Sep 13, 2020

AurevoirXavier commented Sep 13, 2020

hackfisher commented Sep 13, 2020

Fix last confirmed blocks #281

Fix last confirmed blocks #281

Conversation

hackfisher commented Sep 11, 2020 • edited Loading

AurevoirXavier commented Sep 13, 2020

AurevoirXavier commented Sep 13, 2020

hackfisher commented Sep 13, 2020

hackfisher commented Sep 11, 2020 •

edited

Loading