Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Migrate balances to Attribute Macro #593

Merged
merged 10 commits into from
Apr 21, 2021
Merged

Conversation

AurevoirXavier
Copy link
Member

No description provided.

@AurevoirXavier AurevoirXavier added Migration Added C-Substrate [Component] Something about Substrate BK-Storage [Break] This changes storage; next release should be major. S-Need Audit PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Apr 19, 2021
@AurevoirXavier
Copy link
Member Author

2021-04-20 01:53:16 `pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0    
2021-04-20 01:53:16 [#0] 🗳  Finalized election round with compute ElectionCompute::OnChain.    
2021-04-20 01:53:16 [0] 💸 new validator set of size 1 has been processed for era 1    
2021-04-20 01:53:16 [darwinia-claims] Genesis Claims List is Set to EMPTY    
2021-04-20 01:53:16 initializing remote client to "http://pangolin-rpc.darwinia.network"    
2021-04-20 01:53:16 scraping keypairs from remote node http://pangolin-rpc.darwinia.network @ 0x04f3476f6cc491529ac61e8e482187b4d231ef8237b92ecff410599037800e5a    
2021-04-20 01:53:16 downloading data for all modules.    
2021-04-20 01:53:19 extending externalities with 1 manually injected keys    
2021-04-20 01:53:19 injecting a total of 7285 keys    
2021-04-20 01:53:20 Migrating `Instance0Darwinia` to `Ring`...    
2021-04-20 01:53:20 Migrating `Instance1Darwinia` to `Kton`...    
2021-04-20 01:53:20 try-runtime executed without errors. Consumed weight = 1107200000000, total weight = 512000000000000 (0.0021625) 

@AurevoirXavier
Copy link
Member Author

AurevoirXavier commented Apr 19, 2021

branch s2s require this update.

@AurevoirXavier AurevoirXavier added P9 High and removed S-Need Audit PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Apr 19, 2021
@AurevoirXavier
Copy link
Member Author

P9 High

@AsceticBear @hackfisher

Copy link
Contributor

@hackfisher hackfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Suggest do secondary check that module storage prefix names are the only storage migrations need to process.

@hackfisher hackfisher merged commit 4041896 into master Apr 21, 2021
@hackfisher hackfisher deleted the xavier-pallet-balances branch April 21, 2021 04:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
BK-Storage [Break] This changes storage; next release should be major. C-Substrate [Component] Something about Substrate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants