Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

feat: reduce artifical slowdown of the transaction stream #275

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

antouhou
Copy link
Member

Issue being fixed or feature implemented

Slowdown stream time reduced from 1 second/block to 50milliseconds

What was done?

Changed stream slowdown from 1 second/matched Merkle block to 50 milliseconds.
Rationale:
Assuming that an active user makes 5 payments a day on average, with 50 milliseconds slowdown the stream will supply the history for 5 years of active everyday usage in about 8 minutes: 5(years) * 365 * 5(payments a day) / (60 / 0.05) ≈ 7.6, which is a reasonable amount of time.

How Has This Been Tested?

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@antouhou antouhou added this to the v0.14 milestone Jun 19, 2020
@antouhou antouhou self-assigned this Jun 19, 2020
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable! 👍

Copy link
Member

@shuplenkov shuplenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants