Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

fix: bad import namings in platform handlers #292

Merged
merged 1 commit into from
Jul 28, 2020
Merged

fix: bad import namings in platform handlers #292

merged 1 commit into from
Jul 28, 2020

Conversation

shuplenkov
Copy link
Member

@shuplenkov shuplenkov commented Jul 28, 2020 •
edited
Loading

Issue being fixed or feature implemented

Due to the wrong import names, broadcastStateTransition method was broken.

What was done?

Replaced variable names with the right ones.

How Has This Been Tested?

Tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shuplenkov shuplenkov added this to the v0.15 milestone Jul 28, 2020
@shuplenkov shuplenkov requested a review from shumkov July 28, 2020 15:18
shumkov
shumkov approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shuplenkov shuplenkov merged commit fae3ec4 into v0.15-dev Jul 28, 2020
@shuplenkov shuplenkov deleted the fix-naming branch July 28, 2020 16:12
@Mhmonicox Mhmonicox mentioned this pull request Nov 23, 2023
Open
@Mhmonicox Mhmonicox mentioned this pull request Jan 1, 2024
Open
This was referenced Jan 27, 2024
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Feb 7, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Feb 23, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Mar 7, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request May 3, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.15
Development

Successfully merging this pull request may close these issues.
2 participants
@shuplenkov @shumkov